Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): validate configuration after loaded #1427

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

zanminkian
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Currently, cli will not validate nest-cli.json after load it. Developer may not find out his configuration wrong immediately. This PR can increase the development experience.

Issue Number: #692

What is the new behavior?

Validate nest-cli.json after load it. Prevent unexpected fields.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

It may introduce break changes if those nest-cli.jsons are not standard.

@zanminkian zanminkian changed the title Feat/validate configuration after loaded feat(): validate configuration after loaded Nov 28, 2021
@zanminkian zanminkian force-pushed the feat/validate_configuration_after_loaded branch from 40dddc1 to f2093ec Compare November 29, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants